Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-21832] Move Connection type field to the root of the model #169

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Dec 13, 2024

Change Summary

  • Refactored the Connection model to move the type field from connection_data to the root level.
    • Example before:
      {
        "id": 0,
        "group_id": 0,
        "name": "string",
        "description": "string",
        "auth_data": {
          "type": "hive",
          "user": "string"
        },
        "connection_data": {
          "type": "hive",
          "cluster": "string"
        }
      }
    • Example after:
      {
        "id": 0,
        "group_id": 0,
        "name": "string",
        "description": "string",
        "type": "hive",
        "auth_data": {
          "type": "basic",
          "user": "string"
        },
        "connection_data": {
          "cluster": "string"
        }
      }
  • Decoupled auth_data.type from the connection type and linked it to the authentication method instead.
  • Updated Pydantic models to use distinct Connection schemas to accommodate the updated structure.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review December 16, 2024 15:14
@IlyasDevelopment IlyasDevelopment merged commit 7e4d1bc into develop Dec 17, 2024
19 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-21832 branch December 17, 2024 11:17
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3a325f9) to head (6fe6a0a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #169   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants