-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-21832] Move Connection type field to the root of the model #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa8ee77
to
f6e6c1b
Compare
dolfinus
reviewed
Dec 16, 2024
dolfinus
reviewed
Dec 16, 2024
dolfinus
reviewed
Dec 16, 2024
dolfinus
reviewed
Dec 16, 2024
dolfinus
reviewed
Dec 16, 2024
dolfinus
reviewed
Dec 16, 2024
f6e6c1b
to
d01e3ba
Compare
dolfinus
reviewed
Dec 16, 2024
syncmaster/db/migrations/versions/2023-11-23_0004_create_connection_table.py
Outdated
Show resolved
Hide resolved
dolfinus
reviewed
Dec 16, 2024
d01e3ba
to
0124ac0
Compare
0124ac0
to
bfbd0f4
Compare
bfbd0f4
to
6fe6a0a
Compare
dolfinus
approved these changes
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Connection
model to move thetype
field fromconnection_data
to the root level.auth_data.type
from the connection type and linked it to the authentication method instead.Connection
schemas to accommodate the updated structure.Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)