Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-21442] Add Excel API schema #140

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 25, 2024

Change Summary

  • Added API schemas for creating and updating Transfers with file_format=excel.
  • Included parameters for the Excel format:
    • include_header: bool = False (applicable for both reading and writing).
    • start_cell: str | None = None (applicable for both reading and writing).

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Nov 25, 2024
@IlyasDevelopment IlyasDevelopment merged commit 455f99e into develop Nov 25, 2024
16 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-21442 branch November 25, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants