Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-19992] - split settings to different classes #136

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[DOP-19992] - split settings to different classes #136

merged 4 commits into from
Nov 22, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Nov 19, 2024 •
edited
Loading

Change Summary

  • split Settings into independent WorkerSettings, SchedularSettings classes and move corresponding settings attributes from SyncmasterSettings to corresponding classes
  • instead of
    from syncmaster.worker.settings import WorkerSettings as Settings change to
    from syncmaster.worker.settings import WorkerSettings as Settings

to have ability override worker settings via get_worker_settings(CustomWorkerSettings())

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Nov 19, 2024
dolfinus
dolfinus reviewed Nov 19, 2024
View reviewed changes
.env.docker Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov marked this pull request as ready for review November 20, 2024 12:55
@maxim-lixakov maxim-lixakov self-assigned this Nov 20, 2024
dolfinus
dolfinus reviewed Nov 21, 2024
View reviewed changes
.env.local Outdated Show resolved Hide resolved
@dolfinus
Copy link
Member

Tests are failing

@maxim-lixakov
[DOP-19992] - split settings into ServerAppSettings & WorkerAppSettin…
eb73767 
…gs & SchedulerSettings & add corresponding configuration documentation
dolfinus
dolfinus reviewed Nov 21, 2024
View reviewed changes
docker-compose.test.yml Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov enabled auto-merge (squash) November 22, 2024 08:01
@maxim-lixakov maxim-lixakov merged commit 09d052d into develop Nov 22, 2024
16 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-19922 branch November 22, 2024 08:01
@dolfinus dolfinus mentioned this pull request Nov 26, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfinus dolfinus dolfinus approved these changes

@IlyasDevelopment IlyasDevelopment Awaiting requested review from IlyasDevelopment

Assignees

@maxim-lixakov maxim-lixakov

Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxim-lixakov @dolfinus