Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-19926] Grant read-only rights to the previous group owner when ownership is transferred #135

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 19, 2024

Change Summary

Updated group ownership transfer logic: the previous owner now retains read-only access to the group after transferring ownership. The new owner retains the ability to revoke this access if needed.
Added a restriction to the POST /groups/{group_id}/users/{user_id} endpoint to prevent assigning a role to a user who is already a group owner.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Nov 19, 2024
@dolfinus
Copy link
Member

That looks like a duplicate of #134

@IlyasDevelopment
Copy link
Contributor Author

That looks like a duplicate of #134

It is, due to wrong branch name in previous PR

@IlyasDevelopment IlyasDevelopment merged commit 9ede4d5 into develop Nov 19, 2024
16 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-19926 branch November 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants