New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-22993] add transfer schedule #61

Merged

Zabilsya merged 2 commits into develop from feature/DOP-22993

Jan 17, 2025

Contributor

Zabilsya commented Jan 16, 2025 •

edited

Loading

Schedule settings in form:

Show schedule settings for user on transfer detail page:

jellySWATy reviewed

View reviewed changes

src/shared/ui/CronSelect/hooks/useCron/useCron.ts Outdated Show resolved Hide resolved

jellySWATy reviewed

View reviewed changes

src/shared/ui/CronSelect/hooks/useCron/useCron.ts Outdated Show resolved Hide resolved

jellySWATy reviewed

View reviewed changes

src/shared/ui/CronSelect/hooks/useCron/useCron.ts Outdated Show resolved Hide resolved

Member

dolfinus commented Jan 17, 2025

В варианте "раз в месяц" как будто не хватает выбора числа. Кому-то нужно запускать раз в месяц 1 числа, кому-то 15, и т.п.

Contributor Author

Zabilsya commented Jan 17, 2025

В варианте "раз в месяц" как будто не хватает выбора числа. Кому-то нужно запускать раз в месяц 1 числа, кому-то 15, и т.п.

Выбор числа есть, он находится в DynamicSelect компоненте

jellySWATy reviewed

View reviewed changes

src/shared/services/cronService/cronService.ts Show resolved Hide resolved

jellySWATy reviewed

View reviewed changes

src/shared/services/cronService/cronService.ts Show resolved Hide resolved

jellySWATy reviewed

View reviewed changes

src/shared/services/cronService/cronService.ts Show resolved Hide resolved

Member

dolfinus commented Jan 17, 2025

Выбор числа есть, он находится в DynamicSelect компоненте

Я ориентируюсь по скриншоту

Contributor Author

Zabilsya commented Jan 17, 2025

Выбор числа есть, он находится в DynamicSelect компоненте

Я ориентируюсь по скриншоту

Вот же он:

Member

dolfinus commented Jan 17, 2025

Вот же он:

Как-то вообще неочевидно, что это число месяца. 17th я бы еще понял

Contributor Author

Zabilsya commented Jan 17, 2025

Как-то вообще неочевидно, что это число месяца. 17th я бы еще понял

Хорошо, добавлю постфикс еще сюда

Zabilsya force-pushed the feature/DOP-22993 branch from 5a8a3a4 to bb21ccc Compare

January 17, 2025 10:05

jellySWATy reviewed

View reviewed changes

src/shared/ui/CronSelect/hooks/useCron/useCron.ts Outdated Show resolved Hide resolved

jellySWATy approved these changes

View reviewed changes

Zabilsya added 2 commits

January 17, 2025 18:18


          [DOP-22993] add transfer schedule

892c232


          [DOP-22993] rewrite cronService

2a52691

Zabilsya force-pushed the feature/DOP-22993 branch from 5719a27 to 2a52691 Compare

January 17, 2025 12:18

Zabilsya merged commit 65581cb into develop

3 checks passed

Zabilsya deleted the feature/DOP-22993 branch

January 17, 2025 12:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet