Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23149] Replace python-jose with authlib.jose #97

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 9, 2025

Change Summary

python-jose last release version was in 2021. Replace it with a modern library.
In other projects, I've used pyjwt, but here we already use authlib in client code, so reuse it in backend as well.

Bumped version to 1.1.0 as this may influence users.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jan 9, 2025
@dolfinus dolfinus marked this pull request as ready for review January 9, 2025 12:15
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (06df16e) to head (d1add6a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
+ Coverage    91.67%   91.71%   +0.04%     
===========================================
  Files          119      119              
  Lines         2426     2439      +13     
  Branches       141      141              
===========================================
+ Hits          2224     2237      +13     
  Misses         162      162              
  Partials        40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus enabled auto-merge (rebase) January 9, 2025 12:31
@dolfinus dolfinus merged commit cd3a5c5 into develop Jan 9, 2025
16 checks passed
@dolfinus dolfinus deleted the feature/DOP-23149 branch January 9, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants