New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-11675] - add tests to github workflow #5

Merged

maxim-lixakov merged 2 commits into develop from feature/DOP-11675

Feb 8, 2024

Contributor

maxim-lixakov commented Feb 6, 2024 •

edited

Loading

Change Summary

add launching tests to github workflow
update importlib-resources dependency to make it compatible with python 3.7
update Dockerfile: replace building image from corporate artifactory packages with open sourced ones

Related issue number

Checklist

Commit message and PR title is comprehensive
Keep the change as small as possible
Unit and integration tests for the changes exist
Tests pass on CI and coverage does not decrease
Documentation reflects the changes where applicable
docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
(see CONTRIBUTING.rst for details.)
My PR is ready to review.

maxim-lixakov force-pushed the feature/DOP-11675 branch 5 times, most recently from d3f4d9f to 7e00c92 Compare

February 6, 2024 11:53

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

dolfinus reviewed

View reviewed changes

docker/Dockerfile.test Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch 12 times, most recently from d4d96c8 to fa79ed4 Compare

February 6, 2024 13:42

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch from fa79ed4 to 127fe7c Compare

February 6, 2024 13:44

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch 3 times, most recently from 6377c94 to da00944 Compare

February 7, 2024 14:03

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch from da00944 to 4f8a300 Compare

February 7, 2024 14:51

maxim-lixakov force-pushed the feature/DOP-11675 branch 2 times, most recently from b03ae64 to 2799cf7 Compare

February 8, 2024 08:20

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch 3 times, most recently from 91b5da2 to 4978c20 Compare

February 8, 2024 08:35

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch 8 times, most recently from e9d014d to fb23431 Compare

February 8, 2024 11:14

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

maxim-lixakov force-pushed the feature/DOP-11675 branch 2 times, most recently from 4e34c03 to 0617e35 Compare

February 8, 2024 11:23

dolfinus reviewed

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved


          [DOP-11675] - add tests to github workflow

0740ec3

maxim-lixakov force-pushed the feature/DOP-11675 branch from 0617e35 to 0740ec3 Compare

February 8, 2024 11:41

codecov bot commented Feb 8, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Member

dolfinus commented Feb 8, 2024

Добавь по аналогии с onETL вот такой файл, и укажи в нем 90% покрытия:
https://github.com/MobileTeleSystems/onetl/blob/develop/codecov.yml


          [DOP-11675] - add codecov.yml and badges

e2d39f3

dolfinus approved these changes

View reviewed changes

maxim-lixakov merged commit 8917cb0 into develop

12 checks passed

maxim-lixakov deleted the feature/DOP-11675 branch

February 8, 2024 12:53

maxim-lixakov added a commit that referenced this pull request


          [DOP-11675] - add tests to github workflow (#5)

379a46c

* [DOP-11675] - add tests to github workflow

* [DOP-11675] - add codecov.yml and badges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet