Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-14540] Fix Pydantic v2 warnings #47

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Apr 1, 2024

Change Summary

  • Remove Pydantic v2 warnings related to v1 parameter names
  • Fixed CI issue when Pydantic v1 was not installed to venv, and it was not covered by tests

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (c94d748) to head (3f5d943).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #47      +/-   ##
===========================================
+ Coverage    90.68%   91.33%   +0.65%     
===========================================
  Files          120      120              
  Lines         2416     2436      +20     
  Branches       231      240       +9     
===========================================
+ Hits          2191     2225      +34     
+ Misses         174      165       -9     
+ Partials        51       46       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review April 1, 2024 14:20
@dolfinus dolfinus merged commit 8f5ce08 into develop Apr 2, 2024
15 of 16 checks passed
@dolfinus dolfinus deleted the feature/DOP-14540-pydantic-v1 branch April 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants