[DOP-13019] - restrict deletion namespaces with hwms #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-lixakov
requested review from
dolfinus and
dmitry-pedchenko
and removed request for
dolfinus
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25 +/- ##
===========================================
+ Coverage 89.42% 89.43% +0.01%
===========================================
Files 109 109
Lines 2061 2064 +3
Branches 179 180 +1
===========================================
+ Hits 1843 1846 +3
Misses 174 174
Partials 44 44 ☔ View full report in Codecov by Sentry. |
dolfinus
reviewed
Feb 27, 2024
maxim-lixakov
force-pushed
the
feature/DOP-13019
branch
from
79155cb to
9ec6881
Compare
maxim-lixakov
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
dolfinus
approved these changes
Feb 27, 2024
maxim-lixakov
added a commit
that referenced
this pull request
Mar 27, 2024
* [DOP-13016] - add namespace_history table and its api methods * [DOP-13016] - add namespace history client docs * [DOP-13016] - drop 'is_delete' field for User * [DOP-13019] - restrict deletion namespaces with hwms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Namespaceif there are anyhwmsrelated to it.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)