Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-16662] Add Kafka consumer based on FastStream #7

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jul 2, 2024

Change Summary

  • Added consumer extras with FastStream dependency
  • Added arrakis.consumer module with structure similar to arrakis.server
  • Added Kafka container & volume to docker-compose.yml
  • Added tests and documentation for consumer.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jul 2, 2024
@dolfinus dolfinus changed the title Feature/dop 16662 faststream [DOP-16662] Add Kafka consumer based on FastStream Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (861e18e) to head (903cbee).

Files Patch % Lines
arrakis/consumer/settings/security.py 59.25% 6 Missing and 5 partials ⚠️
arrakis/consumer/__init__.py 78.94% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #7      +/-   ##
===========================================
- Coverage    84.10%   83.62%   -0.48%     
===========================================
  Files           61       66       +5     
  Lines          780      849      +69     
  Branches        33       45      +12     
===========================================
+ Hits           656      710      +54     
- Misses         114      124      +10     
- Partials        10       15       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus force-pushed the feature/DOP-16662-faststream branch 2 times, most recently from d06dc99 to 85c3670 Compare July 3, 2024 08:02
@dolfinus dolfinus requested a review from maxim-lixakov July 3, 2024 08:06
@dolfinus dolfinus force-pushed the feature/DOP-16662-faststream branch from 85c3670 to 903cbee Compare July 3, 2024 08:17
@dolfinus dolfinus merged commit 1912bc0 into develop Jul 4, 2024
4 of 5 checks passed
@dolfinus dolfinus deleted the feature/DOP-16662-faststream branch July 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants