Feature/update contribution #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 45 46 +1
Lines 2242 2375 +133
==========================================
+ Hits 2242 2375 +133 ☔ View full report in Codecov by Sentry. |
Closed
feldlime
reviewed
Dec 26, 2023
feldlime
approved these changes
Dec 27, 2023
Closed
blondered
added a commit
that referenced
this pull request
Sep 23, 2024
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/MobileTeleSystems/RecTools/blob/master/CONTRIBUTING.rst --> ## Description <!-- Explain the context and why you're making the change. What is the problem you're trying to solve? --> Updated contribution guide ## Type of change <!-- Please delete/mark options that are/aren't relevant --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Optimization ## How Has This Been Tested? <!-- Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time. - Have you read the contribution guide? - Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself - Does your change require any new tests? - Have you updated the changelog file? Should you feel your tests need an explanation or clarification, please put your description here. Otherwise feel free to remove this section. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated contribution guide
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.