Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/model from params #252

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Feature/model from params #252

merged 7 commits into from
Feb 4, 2025

Conversation

feldlime
Copy link
Collaborator

@feldlime feldlime commented Feb 1, 2025

Description

  • Added from_params method for models and model_from_params function

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (c489187).
Report is 93 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #252     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        60     +15     
  Lines         2242      4033   +1791     
===========================================
+ Hits          2242      4033   +1791     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feldlime feldlime requested a review from blondered February 1, 2025 22:58
blondered
blondered previously approved these changes Feb 4, 2025
@feldlime feldlime merged commit 5664a3c into main Feb 4, 2025
10 checks passed
@feldlime feldlime deleted the feature/model_from_params branch February 4, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants