Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/torch install on macosx x86 64 #143

Merged
merged 12 commits into from
May 18, 2024
Merged

Bugfix/torch install on macosx x86 64 #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
658b75a
used the latest lightfm revision
feldlime May 17, 2024
2414b77
used poetry-core instead of poetry as a build backend
feldlime May 17, 2024
f717a6f
updated lock file
feldlime May 17, 2024
03ec9a5
removed poetry old version restrictions
feldlime May 17, 2024
92ee121
updated changelog
feldlime May 17, 2024
5a680b9
returned <3.12 restriction for lightfm
feldlime May 17, 2024
6601640
removed poetry version warning from readme
feldlime May 17, 2024
92e67a7
added PR number to changelog
feldlime May 17, 2024
dc34029
added comments to lightfm version
feldlime May 17, 2024
77a921c
added torch version restriction
feldlime May 18, 2024
0eae938
updated changelog
feldlime May 18, 2024
7cdf2cb
Merge branch 'main' into bugfix/torch_install_on_macosx_x86_64
feldlime May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Extended Theory&Practice RecSys baselines tutorial ([#139](https://github.com/MobileTeleSystems/RecTools/pull/139))

### Changed
- Used the latest version of `lightfm` that allows to install it using `poetry 1.5.0+` ([#141](https://github.com/MobileTeleSystems/RecTools/pull/141))
### Fixed
- Used the latest version of `lightfm` that allows to install it using `poetry>=1.5.0` ([#141](https://github.com/MobileTeleSystems/RecTools/pull/141))
- Added restriction to `pytorch` version for MacOSX + x86_64 that allows to install it on such platforms ([#142](https://github.com/MobileTeleSystems/RecTools/pull/142))


## [0.6.0] - 13.05.2024
Expand Down
103 changes: 97 additions & 6 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ lightfm = {git = "https://github.com/lyst/lightfm", rev = "0c9c31e", python = "<

nmslib = {version = "^2.0.4", python = "<3.11", optional = true}

torch = {version = ">=1.6.0, <3.0.0", optional = true}
# The latest torch version available for MacOSX + x86_64 is 2.2.2
torch = [
{version = ">=1.6.0, <2.3.0", markers = "sys_platform == 'darwin' and platform_machine == 'x86_64'", optional = true},
{version = ">=1.6.0, <3.0.0", optional = true}
]
pytorch-lightning = {version = ">=1.6.0, <3.0.0", optional = true}

ipywidgets = {version = ">=7.7,<8.2", optional = true}
Expand Down
Loading