forked from motis-project/motis
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert components to shadcn-svelte #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoPhliFra
commented
Jan 7, 2025
- shadcn-svelte installed and new components added (the way it was documented in wiki)
- old components especially button.svelte was deleted because no longer needed
- component are just like og motis devs intended with folders and index files
upload logic rewrite for new components
previously existing components were replaced with shadcn-svelte comonents and can now be deleted
Kha1r0
approved these changes
Jan 7, 2025
Kvnstrck
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document components
D3vZro
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the PR title to conform conventional commits. This also creates a proper squash commit title on merge.
nicosvv
approved these changes
Jan 8, 2025
D3vZro
approved these changes
Jan 8, 2025
Kvnstrck
approved these changes
Jan 8, 2025
7298b6b
to
a8b6b4b
Compare
D3vZro
added a commit
that referenced
this pull request
Jan 26, 2025
* feat: initialize shadcn * feat: add shadcn-svelte base components upload logic rewrite for new components * chore: update button for backend * chore: delete unnecessary components previously existing components were replaced with shadcn-svelte comonents and can now be deleted * fix: fix classnames for button * fix: fix toggle components --------- Co-authored-by: Toni Nguyen <d3vzero@outlook.de> Co-authored-by: Kvnstrck <strackekevin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.