Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min temperature too high #7

Open
zaedas opened this issue Jan 24, 2021 · 2 comments
Open

Min temperature too high #7

zaedas opened this issue Jan 24, 2021 · 2 comments

Comments

@zaedas
Copy link

zaedas commented Jan 24, 2021

Hello,

First of all, thank you for working on that script. It works well.

After tweaking my settings a bit on node-red (i was trying to automate my heatpump), i noticed i was getting errors when i was setting my temperature lower than 18C. My heatpump support a temperature range of 16 - 32. The entity on home assistant confirms this.

I noticed that you placed a low ceiling of 180 in splitAC.py (line 180ish). Here's a snippet :

    def changeTemperature(self,newTemperature):
        ## set temperature for degree C
        if not isinstance(newTemperature,int) and not isinstance(newTemperature,float):
            raise Exception('Wrong usage of method')
        ## Fixing temps if not given as multiplies of 10 less than 180
        if newTemperature < 180:
            newTemperature = newTemperature * 10
        if (newTemperature >= 180 and newTemperature <= 320):
            self.adjust_temperature = newTemperature
        else:
            raise Exception('out of range temperature!!')

After changing 180 for 160, i don't have any problems on my end anymore.

Should i push this change to the repo, or was the limit of 180 there for some reason?

Thanks again for your work

@balouken
Copy link

balouken commented Nov 6, 2021

Hello,

First of all, thank you for working on that script. It works well.

After tweaking my settings a bit on node-red (i was trying to automate my heatpump), i noticed i was getting errors when i was setting my temperature lower than 18C. My heatpump support a temperature range of 16 - 32. The entity on home assistant confirms this.

I noticed that you placed a low ceiling of 180 in splitAC.py (line 180ish). Here's a snippet :

    def changeTemperature(self,newTemperature):
        ## set temperature for degree C
        if not isinstance(newTemperature,int) and not isinstance(newTemperature,float):
            raise Exception('Wrong usage of method')
        ## Fixing temps if not given as multiplies of 10 less than 180
        if newTemperature < 180:
            newTemperature = newTemperature * 10
        if (newTemperature >= 180 and newTemperature <= 320):
            self.adjust_temperature = newTemperature
        else:
            raise Exception('out of range temperature!!')

After changing 180 for 160, i don't have any problems on my end anymore.

Should i push this change to the repo, or was the limit of 180 there for some reason?

Thanks again for your work

Cooling is limited to 18°C.
Heating is limited to 16°C.

If you gonne use 16°C for cooling, the indoorunit will not except it.

@Rydcal
Copy link

Rydcal commented Jan 30, 2022

Another vote.

Would be great for my use case if we could change the stanza in splitAC.py to:

def changeTemperature(self,newTemperature):
        ## set temperature for degree C
        if not isinstance(newTemperature,int) and not isinstance(newTemperature,float):
            raise Exception('Wrong usage of method')
        ## Fixing temps if not given as multiplies of 10 less than 160
        if newTemperature < 160:
            newTemperature = newTemperature * 10
        if (newTemperature >= 160 and newTemperature <= 320):
            self.adjust_temperature = newTemperature
        else:
            raise Exception('out of range temperature!!')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants