Skip to content

Latest commit

 

History

History
executable file
·
12 lines (12 loc) · 504 Bytes

PULL_REQUEST_TEMPLATE.md

File metadata and controls

executable file
·
12 lines (12 loc) · 504 Bytes

CHECK LIST

  • specs added
  • specs passed
  • code coverage >90%
  • DB indexes added if needed
  • seed.rb file is updated if needed
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • PR doesn't have conflicts with main branch
  • I've checked new feature as logged in and logged out user if needed
  • "let!" is used in specs
  • screenshot of rails_best_practices and other tools added
  • screenshot of feature is added if task has UI