Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete doesn't invalidate the cache #15

Open
nephlm opened this issue Mar 15, 2018 · 2 comments
Open

Delete doesn't invalidate the cache #15

nephlm opened this issue Mar 15, 2018 · 2 comments
Assignees
Labels
bug Waiting on PyPI Fixed in Master, waiting on PyPI to be updated

Comments

@nephlm
Copy link
Contributor

nephlm commented Mar 15, 2018

If you instantiate NoDB and set cache to True, then you can save and object and delete the object.

If you load the object at at this point, the deleted object will be returned since it's still in the cache. Delete is not cache aware; it deletes from the s3 bucket, but doesn't update the cache.

nodb=NoDB()
nodb.cache=True
nodb.index = 'name'
nodb.save({'name': 'jeff', 'age': 19})
nodb.delete('jeff')
nodb.load('jeff') #=> {'name': 'jeff', 'age': 19}

That's probably not the expected behavior.

@bendog bendog added the bug label Sep 12, 2019
@bendog
Copy link
Collaborator

bendog commented Sep 12, 2019

should probably start by writing a test case for this

@bendog bendog self-assigned this Sep 12, 2019
@bendog bendog added Waiting on PyPI Fixed in Master, waiting on PyPI to be updated and removed Fixed in PR labels Nov 18, 2019
@bendog
Copy link
Collaborator

bendog commented Nov 18, 2019

Merged into master, waiting on PyPi update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Waiting on PyPI Fixed in Master, waiting on PyPI to be updated
Projects
None yet
Development

No branches or pull requests

2 participants