Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

功能更新 #1

Merged
merged 1 commit into from
Jan 1, 2025
Merged

功能更新 #1

merged 1 commit into from
Jan 1, 2025

Conversation

jnQaQ
Copy link

@jnQaQ jnQaQ commented Jan 1, 2025

追加bouns设置与显示功能、追加标记含有非ascii符号曲目功能

Copy link
Owner

@Misaka12456 Misaka12456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哎 如何评价呢
抽象缩进(tab空格混用)
还有一些看起来像是不怎么经常写C#导致的(比如可以直接用string.IsNullOrEmpty()的地方用了xxx == null || xxx.Length == 0)
大体上没问题 我merge了之后格式化下(

@@ -57,6 +58,46 @@ private static void GameInit(string[] args)
Console.WriteLine("Add the revealed letter EVEN THOUGH the letter doesn't exist in any song title?\n" +
"By enabling this feature, the revealed letter list will act better as a hint list, which was widely used in the real game chat before. (Y/n)");
bool preserveAnyRevealedLetter = (Console.ReadLine() ?? string.Empty).Trim().ToLower() != "n";

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好抽象的换行啊(

{
Console.WriteLine("If you want to confirm that you don't set the bonus, please enter the enter again to confirm.");
string? confirmString = Console.ReadLine();
if (confirmString == null||confirmString.Length == 0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以直接string.IsNullOrEmpty(confirmString)

@Misaka12456 Misaka12456 merged commit 6155245 into Misaka12456:master Jan 1, 2025
1 check passed
Misaka12456 added a commit that referenced this pull request Jan 1, 2025
- New feature: Highlight songs which name contain non-ASCII character(s) and bonus songs (#1)
- Fixed other known issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants