Private type on public interface makes it hard to mock out the response

[aliotta]

The following List endpoint returns a type that is not made public making it difficult to make an interface for this method.

metronome-go/customerinvoice.go

Line 59 in 70b3a86

func (r *CustomerInvoiceService) List(ctx context.Context, customerID string, query CustomerInvoiceListParams, opts ...option.RequestOption) (res *pagination.CursorPage[Invoice], err error) {

[dgellow]

Hi @aliotta,

Could you clarify what type is causing issues for you? Both pagination.CursorPage and Invoice seem to be public as far as I can tell.

[aliotta]

Its the pagination param.

e.g. the following does not work as I do not have a reference to the pagination package.

import (
	"context"
	"os"
	"metronomeSDK "github.com/Metronome-Industries/metronome-go"
	"github.com/Metronome-Industries/metronome-go/option"
)

func (gl *metronomeV2Client) ListInvoice(ctx context.Context, customerId string, invoiceId string, body metronomeSDK.CustomerInvoiceListParams) (res *metronomeSDK.Pagination.CursorPage[metronomeSDK.Invoice], err error) {
	return gl.client.Customers.Invoices.List(ctx, customerId, body)
}

[dgellow]

Ah, you're perfectly right, pagination is under internal. That's definitely problematic. Thank you for the report, we are looking into it.

[dgellow]

Hi @aliotta, thanks for your patience, the issue has been fixed with this commit.

That will be part of the next release.