More examples #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codewithgun
force-pushed
the
feat/more-example
branch
3 times, most recently
from
5954ab2 to
45d509d
Compare
codewithgun
force-pushed
the
feat/more-example
branch
from
45d509d to
565e375
Compare
| @@ -137,15 +137,15 @@ async fn test_initialize_customizable_permissionless_pool() { | |||
| test.add_program("metaplex", METAPLEX_PROGRAM_ID, None); | |||
|
|
|||
| let jup_vault = setup_vault_from_cluster(&mut test, JUP, mock_user.pubkey()).await; | |||
| let sol_vault = setup_vault_from_cluster(&mut test, USDC, mock_user.pubkey()).await; | |||
| let usdc_vault = setup_vault_from_cluster(&mut test, USDC, mock_user.pubkey()).await; | |||
|
|
|||
| let (mut banks_client, _, _) = test.start().await; | |||
|
|
|||
| let pool_key = derive_customizable_permissionless_constant_product_pool_key(JUP, USDC); | |||
| let lp_mint = derive_lp_mint(pool_key); | |||
|
|
|||
| let a_vault_lp = derive_vault_lp_key(jup_vault.key, pool_key); | |||
There was a problem hiding this comment.
- I think we should make helper to a common lib, so integration know how to derive all accounts in meteora
- Make some function like: get_accounts_for_initialize_customizable_permissionless_pool()
- For SOL/USDC/USDT in mainnet, we should make lp_vault hardcoded, caused it is not PDA in mainnet (many integrators are struggled when integrating with that)
There was a problem hiding this comment.
Fixed. Could you review the related PRs too?
MeteoraAg/dynamic-amm-sdk#195
MeteoraAg/stake-for-fee-sdk#28
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.