Skip to content

update instances of collectibles to nfts #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

update instances of collectibles to nfts #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3a6e5b4
update instances of collectibles to nfts
NidhiKJha Dec 13, 2022
006ad1e
added new byte code for nfts
NidhiKJha Dec 16, 2022
a47f798
updated nft casing
NidhiKJha Dec 16, 2022
ad88ff4
updated nftsMint to safeMint
NidhiKJha Dec 16, 2022
eef2b34
fixed lint errors and removed collectibles
NidhiKJha Dec 20, 2022
4700f55
updated abi and byte code
NidhiKJha Jan 18, 2023
c7f03b7
updated constants
NidhiKJha Feb 14, 2023
183c65d
nit fix
NidhiKJha Feb 14, 2023
f80b16e
updated contract
NidhiKJha Feb 15, 2023
a7a0464
updated sol
NidhiKJha Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions contracts/TestDappCollectibles.sol → contracts/TestDappNFTs.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,21 @@
// SPDX-License-Identifier: MIT
pragma solidity >=0.4.22 <0.9.0;

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tried compiling this in Remix but got an error about Strings already being declared. I don't quite understand why, but, it went away with I removed the @4.8.1 or added it to the other two imports. Perhaps they should all be using the same version of @openzeppelin/contracts.

import "@openzeppelin/contracts@4.8.1/token/ERC721/ERC721.sol";
import "@openzeppelin/contracts/utils/Counters.sol";
import "@openzeppelin/contracts/utils/Strings.sol";
import 'base64-sol/base64.sol';

contract TestDappCollectibles is ERC721 {
contract TestDappNfts is ERC721 {

using Counters for Counters.Counter;
Counters.Counter private _tokenIds;

constructor() ERC721('TestDappCollectibles', 'TDC') {}
constructor() ERC721("NFT Token", "NFT") {}

function mintCollectibles(uint numberOfTokens) public {
for(uint i = 1; i <= numberOfTokens; i++) {
_tokenIds.increment();
uint tokenId = _tokenIds.current();
_safeMint(_msgSender(), tokenId);
function safeMint(uint256 tokenId) public {
_safeMint(msg.sender, tokenId);
}
}

function tokenURI(uint tokenId) public pure override returns (string memory) {
string memory svg =
Expand All @@ -37,9 +33,9 @@ contract TestDappCollectibles is ERC721 {

string memory json = string(
abi.encodePacked(
'{"name": "Test Dapp Collectibles #',
'{"name": "Test Dapp NFTs #',
Strings.toString(tokenId),
'", "description": "Test Dapp Collectibles for testing.", "image": "data:image/svg+xml;base64,',
'", "description": "Test Dapp NFTs for testing.", "image": "data:image/svg+xml;base64,',
Base64.encode(bytes(svg)),
'", "attributes": [{"trait_type": "Token Id", "value": "',
Strings.toString(tokenId),
Expand Down
Loading