NFT: Replaced all the instances of collectibles with NFTs #17741

NidhiKJha · 2023-02-14T09:38:37Z

We're moving from using the term "collectible" to always using "NFT". This PR updates the associated variables and instances of collectibles to NFT.

TODO: Update the TestDappCollectibles change once this PR is merged.

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in the browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

metamaskbot · 2023-02-14T12:29:24Z

Builds ready [5bc87e6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1308 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	319	124	47	22
		domContentLoaded	993	1797	1274	253	121
		load	1022	1798	1308	240	115
		domInteractive	993	1797	1274	253	121

Bundle size diffs [🚀 Bundle size reduced!]

background: -48 bytes
ui: -1296 bytes
common: 0 bytes

metamaskbot · 2023-02-14T14:01:32Z

Builds ready [f535fcd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1331 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	249	135	33	16
		domContentLoaded	1041	1799	1301	226	109
		load	1042	1910	1331	236	113
		domInteractive	1041	1799	1301	226	109

Bundle size diffs [🚀 Bundle size reduced!]

background: -48 bytes
ui: -1295 bytes
common: 0 bytes

metamaskbot · 2023-02-14T14:17:08Z

Builds ready [f535fcd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1370 ± 138 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	158	125	17	8
		domContentLoaded	1011	1856	1335	280	134
		load	1081	1872	1370	287	138
		domInteractive	1011	1856	1335	280	134

Bundle size diffs [🚀 Bundle size reduced!]

background: -48 bytes
ui: -1295 bytes
common: 0 bytes

metamaskbot · 2023-02-14T14:20:08Z

Builds ready [f535fcd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1494 ± 148 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	105	185	128	18	9
		domContentLoaded	1102	1940	1464	297	143
		load	1102	1965	1494	308	148
		domInteractive	1102	1940	1464	297	143

Bundle size diffs [🚀 Bundle size reduced!]

background: -48 bytes
ui: -1295 bytes
common: 0 bytes

app/scripts/controllers/app-state.js

metamaskbot · 2023-02-15T17:35:30Z

Builds ready [30eb9a3]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1574 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	137	114	11	5
		domContentLoaded	1291	1657	1525	97	46
		load	1329	1717	1574	98	47
		domInteractive	1291	1657	1525	97	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 894 bytes
ui: -1295 bytes
common: 0 bytes

metamaskbot · 2023-02-16T17:06:59Z

Builds ready [57bcd3b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1668 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	190	126	24	11
		domContentLoaded	1315	2041	1640	187	90
		load	1315	2097	1668	201	96
		domInteractive	1315	2041	1639	187	90

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 894 bytes
ui: -1287 bytes
common: 0 bytes

NidhiKJha requested review from a team and kumavis as code owners February 14, 2023 09:38

NidhiKJha requested a review from PeterYinusa February 14, 2023 09:38

NidhiKJha added area-NFTs team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 14, 2023

NidhiKJha requested a review from darkwing February 14, 2023 14:33

darkwing reviewed Feb 14, 2023

View reviewed changes

app/scripts/controllers/app-state.js Show resolved Hide resolved

darkwing reviewed Feb 14, 2023

View reviewed changes

app/scripts/controllers/app-state.js Show resolved Hide resolved

NidhiKJha requested a review from darkwing February 15, 2023 14:12

NidhiKJha force-pushed the fix-14502-c branch from 6db63fe to c2542aa Compare February 15, 2023 15:25

NidhiKJha added 14 commits February 16, 2023 22:13

replaced all the instances of collectibles with nfts

a54528c

updated actions

0cbc013

updated e2e seeder

2a03451

updated confirm Approve test

15b25e2

updated test dapp change

a0d27d6

updated test dapp change

dbb6fe7

nit fix

1a41dae

nit fix

98e0c97

updated casing and snapshots

b6b70a0

updated casinG

0269b22

added migrations

447b4ff

updated ,igration

02fe842

updated 078.test

c3503c3

updated tests for 078 migration

b92b10a

NidhiKJha added 2 commits February 16, 2023 22:13

updated migration

9ebcf98

updated 078 index.js

57bcd3b

NidhiKJha force-pushed the fix-14502-c branch from 30eb9a3 to 57bcd3b Compare February 16, 2023 16:43

darkwing approved these changes Feb 16, 2023

View reviewed changes

vthomas13 approved these changes Feb 16, 2023

View reviewed changes

NidhiKJha merged commit 33cc8d5 into develop Feb 16, 2023

NidhiKJha deleted the fix-14502-c branch February 16, 2023 19:23

github-actions bot locked and limited conversation to collaborators Feb 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NFT: Replaced all the instances of collectibles with NFTs #17741

NFT: Replaced all the instances of collectibles with NFTs #17741

NidhiKJha commented Feb 14, 2023 •

edited

Loading

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 15, 2023

metamaskbot commented Feb 16, 2023

NFT: Replaced all the instances of collectibles with NFTs #17741

NFT: Replaced all the instances of collectibles with NFTs #17741

Conversation

NidhiKJha commented Feb 14, 2023 • edited Loading

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 14, 2023

metamaskbot commented Feb 15, 2023

metamaskbot commented Feb 16, 2023

NidhiKJha commented Feb 14, 2023 •

edited

Loading