Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more components to Snaps Custom UI #1835

Merged
merged 19 commits into from
Jan 27, 2025
Merged

Add more components to Snaps Custom UI #1835

merged 19 commits into from
Jan 27, 2025

Conversation

Montoya
Copy link
Collaborator

@Montoya Montoya commented Jan 24, 2025 •
edited
Loading

Description

Adds multiple Snaps components that were previously undocumented including Banner, Container, Footer, Value

This PR was made with Cursor AI. I have attempted to the best of my ability to make sure these edits are accurate.

Issue(s) fixed

This fixes #1797

Preview

https://metamask-docs-git-more-snaps-custom-u-b05c97-consensys-ddffed67.vercel.app/snaps/features/custom-ui/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@Montoya
Add more components to Snaps Custom UI
464f534 
This PR was made with Cursor AI. I have attempted to the best of my ability to make sure these edits are accurate.
@Montoya Montoya requested review from a team as code owners January 24, 2025 05:14
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 6:07pm

alexandratran
alexandratran reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for consistency.

Montoya and others added 6 commits January 24, 2025 16:09
@Montoya @alexandratran
Separate links per component in what's new
de50322 
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
@Montoya @alexandratran
Update Banner description text
0ef7a18 
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
@Montoya @alexandratran
Update props for container
f23520d 
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
@Montoya @alexandratran
Update footer description
f6cc29f 
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
@Montoya @alexandratran
Update footer props
685e711 
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
@Montoya @alexandratran
Update Value props
61cfd06 
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
alexandratran
alexandratran reviewed Jan 26, 2025
View reviewed changes
alexandratran
alexandratran previously approved these changes Jan 26, 2025
View reviewed changes
@Montoya
Cleanup
f7cc3b1 
Remove erroneous message about Address tooltip

Make checkbox variant prop description match style of document.

Make Skeleton defaults descriptions match style of document.
@Montoya Montoya merged commit b838a49 into main Jan 27, 2025
21 checks passed
@Montoya Montoya deleted the more-snaps-custom-ui-components branch January 27, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snaps: Document Footer component
3 participants
@Montoya @FrederikBolding @alexandratran