Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ref): act-1538 - added response example to ref pages #1579

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

TrofimovAnton85
Copy link
Contributor

Description

  • Added Response Example to the Reference Pages

Test

  • Go to the wallet ref page /wallet/reference/eth_chainid/ and check that the right column displays the default response example
  • Click "Run request" button and check that the response has changed
  • Click "Response reset" (reset icon) and make sure that the default example has returned

Screenshot 2024-09-26 at 15 35 44

https://infura.atlassian.net/browse/ACT-1538

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 1:39pm

Copy link
Contributor

@cedricmagne cedricmagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it works.
Screenshot 2024-09-26 at 15 44 05
Screenshot 2024-09-26 at 15 44 25
Just for my understanding why the Connect wallet button is not hidden because when running the request we are using the chainId connected with Metamask

@TrofimovAnton85 TrofimovAnton85 merged commit a1f32ea into main Sep 26, 2024
9 checks passed
@TrofimovAnton85 TrofimovAnton85 deleted the feat-ref-response branch September 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants