docs(1367): tidy up for tutorials #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexandratran
previously approved these changes
Jul 10, 2024
proof Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
proof Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
proof Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
|
yarn install is fine for yarn path, but need alt for the npm ... |
|
Ziad suggesting that as yarn is the only install that will work, we should just remove the npm and npx options >> need to apply |
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
Signed-off-by: m4sterbunny <harrie.bickle@consensys.net>
proof Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
proof Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Comment on lines
162
to
164
| "type": "git", | ||
| "url": "https://github.com/MetaMask/template-snap-monorepo.git" | ||
| }, |
There was a problem hiding this comment.
OK, I see this comment here now. I prefer just the relevant fragments. I find the tabs with the full file a bit confusing. If it makes sense, you can add an ellipses "..." before the closing bracket to denote additional text.
alexandratran
previously approved these changes
Aug 2, 2024
m4sterbunny
commented
Aug 2, 2024
alexandratran
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update attempts to allow both tutorials to be a quick "hello world" AND to present best practice // further considerations that a serious snaps dev needs
Both tutorials:
Makes clear that icon step is optional (although recommended) -- adds optional steps that allow all UX to match tutorial function. Improves numbering of 5 and removes 6 (not a step)
Zaid also improved the referenced icon to be visible in dark mode
Issue(s) fixed
Fixes #1367