Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Custom UI examples to JSX #1348

Merged
merged 18 commits into from
Jul 31, 2024
Merged

Translate Custom UI examples to JSX #1348

merged 18 commits into from
Jul 31, 2024

Conversation

ziad-saab
Copy link
Contributor

@ziad-saab ziad-saab commented Jun 11, 2024

Description

  • Translate Custom UI examples to JSX
  • Add flaskOnly prop for TabItem
  • Add deprecation warning on Custom UI page
  • Add Custom UI with JSX page

Issue(s) fixed

Fixes #

Preview

image

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@ziad-saab ziad-saab requested review from a team as code owners June 11, 2024 19:53
@ziad-saab ziad-saab marked this pull request as draft June 11, 2024 19:53
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:21pm
metamask-docs-hftx ❌ Failed (Inspect) Jul 31, 2024 1:21pm

@ziad-saab ziad-saab marked this pull request as ready for review June 12, 2024 16:44
@ziad-saab ziad-saab requested a review from Montoya June 12, 2024 16:44
@ziad-saab ziad-saab changed the title Translate Custom UI examples to JSX [WIP] Translate Custom UI examples to JSX Jun 12, 2024
Copy link

Preview published: zs/snaps-jsx

Copy link

Preview published: zs/snaps-jsx

1 similar comment
Copy link

Preview published: zs/snaps-jsx

@hmalik88
Copy link
Contributor

Probably important to mention somewhere that JSX syntax will only work with .tsx or .jsx files

@Montoya
Copy link
Collaborator

Montoya commented Jun 12, 2024

Probably important to mention somewhere that JSX syntax will only work with .tsx or .jsx files

Just did that in my commit

Montoya
Montoya previously approved these changes Jun 12, 2024
Copy link

Preview published: zs/snaps-jsx

alexandratran
alexandratran previously approved these changes Jun 13, 2024
Copy link

Preview published: zs/snaps-jsx

@Montoya Montoya self-requested a review June 13, 2024 20:35
Montoya
Montoya previously approved these changes Jun 13, 2024
@Montoya
Copy link
Collaborator

Montoya commented Jun 13, 2024

This technically should not be merged until June 20....

@alexandratran alexandratran dismissed stale reviews from Montoya and themself via b934943 June 20, 2024 19:33
alexandratran
alexandratran previously approved these changes Jun 20, 2024
@alexandratran
Copy link
Contributor

@Montoya Is this ready to merge?

@Montoya
Copy link
Collaborator

Montoya commented Jul 15, 2024

Almost ready to merge @alexandratran as soon as Extension and Flask v12 are published

Mrtenz
Mrtenz previously approved these changes Jul 15, 2024
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please wait with merging until v12 of the extension is live.

@ziad-saab ziad-saab dismissed stale reviews from Mrtenz and alexandratran via 65dc7f4 July 22, 2024 20:28
alexandratran
alexandratran previously approved these changes Jul 23, 2024
And fix link to tx insights feature
@Montoya Montoya merged commit c56eaf5 into main Jul 31, 2024
9 checks passed
@Montoya Montoya deleted the zs/snaps-jsx branch July 31, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants