Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Snaps lifecycle hooks #1077

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Add documentation for Snaps lifecycle hooks #1077

merged 4 commits into from
Jan 5, 2024

Conversation

Montoya
Copy link
Collaborator

@Montoya Montoya commented Jan 4, 2024

This closes #1076

@Montoya Montoya requested review from a team as code owners January 4, 2024 21:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Preview published: snaps-lifecycle-hooks

FrederikBolding
FrederikBolding reviewed Jan 5, 2024
View reviewed changes
Montoya and others added 2 commits January 5, 2024 09:38
@Montoya @FrederikBolding
Remove return section
dd667eb 
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
@Montoya @FrederikBolding
Remove return section 2
1e50908 
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Preview published: snaps-lifecycle-hooks

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Preview published: snaps-lifecycle-hooks

@Montoya Montoya added snaps Related to Snaps content. team-snaps-platform labels Jan 5, 2024
@alexandratran alexandratran self-assigned this Jan 5, 2024
alexandratran
alexandratran approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Preview published: snaps-lifecycle-hooks

@Montoya Montoya merged commit e4c3b44 into main Jan 5, 2024
6 checks passed
@Montoya Montoya deleted the snaps-lifecycle-hooks branch January 5, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees

@alexandratran alexandratran

Labels
snaps Related to Snaps content. team-snaps-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document lifecycle-hooks for Snaps
3 participants
@Montoya @FrederikBolding @alexandratran