Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CH-169
Fixes CH-134
Implemented solution
Changed the scripts to check whether the harness.deployment.image is set and ignore the build in that case, even if a dockerfile is present.
On the side, removed the build for the nfs-server using this implemented strategy, as that build currently fails and is not necessary.
How to test this PR
Set harness.deployment.image to something and verify that skaffold and codefresh script do not contain that build, and the image is correctly set in values.yaml
The new functionality behaviours are fully covered in unit tests.
Sanity checks:
Breaking changes (select one):
breaking-change
and the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):