New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special handling of stop with concatentation #2

Open

1 of 2 tasks

hiker opened this issue Nov 26, 2024 · 1 comment

Open

1 of 2 tasks

Remove special handling of stop with concatentation #2

hiker opened this issue Nov 26, 2024 · 1 comment

Assignees

Collaborator

hiker commented Nov 26, 2024 •

edited

Loading

With the release of fparser 0.2, this is not necessary anymore:

Update dependency on fparser
Remove the stop handling code

hiker mentioned this issue

Update to fparser2 0.2.0 MetOffice/fab#364

Open

4 tasks

Collaborator Author

hiker commented Feb 4, 2025

The special handling of stop concatentation can be removed now. Affected files:

./infrastructure/build/fab/lfric_base.py:from lfric_common import configurator, fparser_workaround_stop_concatenation
./infrastructure/build/fab/lfric_base.py:        fparser_workaround_stop_concatenation(self.config)
./infrastructure/build/fab/lfric_common.py:def fparser_workaround_stop_concatenation(config):
`

hiker assigned jasonjunweilyu

jasonjunweilyu mentioned this issue

Remove stop concatenation #15

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment