Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter dsiplays only parent notes issue - EXO-75447 - Meeds-io/meeds#2616. #1226

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

akhanfir
Copy link
Contributor

Before this change, when open drawer of note filter and serach for a sub-level note, only first level parent notes are displayed and sub-level notes are never displayed. To resolve this problem, consume the rest of the unified search filter service for the published notes and for the draft filter using the list already retrieved. After this change, Sub-level notes is displayed in notes filter search results.

@akhanfir akhanfir requested a review from mkrout November 26, 2024 13:32
@akhanfir akhanfir enabled auto-merge (squash) November 26, 2024 13:32
@exo-swf exo-swf force-pushed the feature/maintenance branch from bffd26e to a93554a Compare November 27, 2024 00:17
…eeds#2616.

Before this change, when open drawer of note filter and serach for a sub-level note, only first level parent notes are displayed and sub-level notes are never displayed. To resolve this problem, consume the rest of the unified search filter service for the published notes and for the draft filter using the list already retrieved. After this change, Sub-level notes is displayed in notes filter search results.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.9% Coverage on New Code (required ≥ 60%)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@akhanfir akhanfir merged commit 874de42 into feature/maintenance Nov 27, 2024
3 of 4 checks passed
@akhanfir akhanfir deleted the TASK-75447 branch November 27, 2024 11:41
Jihed525 pushed a commit that referenced this pull request Nov 27, 2024
…eeds#2616. (#1226)

Before this change, when open drawer of note filter and serach for a
sub-level note, only first level parent notes are displayed and
sub-level notes are never displayed. To resolve this problem, consume
the rest of the unified search filter service for the published notes
and for the draft filter using the list already retrieved. After this
change, Sub-level notes is displayed in notes filter search results.

(cherry picked from commit 874de42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants