Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note Featured images not correctly imported #2499

Closed
hakermi opened this issue Oct 16, 2024 · 0 comments · Fixed by Meeds-io/notes#1179
Closed

Note Featured images not correctly imported #2499

hakermi opened this issue Oct 16, 2024 · 0 comments · Fixed by Meeds-io/notes#1179
Assignees
Labels

Comments

@hakermi
Copy link
Member

hakermi commented Oct 16, 2024

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to Notes app
  2. Create some notes with featured images
  3. Click on export notes
  4. Import the note a different platform instance
  5. Check your imported notes

Current behaviour

No featured images imported

Expected behavior

Featured images should be correctly imported

hakermi added a commit to Meeds-io/notes that referenced this issue Oct 16, 2024
Prior to this change, when import notes with featured images, the featured image are not correctly imported due to wrong extractin of featuredId from exported fileName
beside a wrong handle of different conflict actions.
This PR makes sure to correctly extarct the export featured image id to correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 16, 2024
Prior to this change, when import notes with featured images, the featured image are not correctly imported due to wrong extractin of featuredId from exported fileName
beside a wrong handle of different conflict actions.
This PR makes sure to correctly extarct the export featured image id to correctly import featured images.
@hakermi hakermi self-assigned this Oct 16, 2024
@hakermi hakermi added this to Bug Hunt Oct 16, 2024
@hakermi hakermi moved this to Doing in Bug Hunt Oct 16, 2024
@hakermi hakermi added the Notes label Oct 16, 2024
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
exo-swf pushed a commit to Meeds-io/notes that referenced this issue Oct 16, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
exo-swf pushed a commit to Meeds-io/notes that referenced this issue Oct 17, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
exo-swf pushed a commit to Meeds-io/notes that referenced this issue Oct 17, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 18, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 18, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 18, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extarct the export featured image id to
correctly import featured images.
hakermi added a commit to Meeds-io/notes that referenced this issue Oct 18, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extract the export featured image id to
correctly import featured images.
@github-project-automation github-project-automation bot moved this from Doing to Done in Bug Hunt Oct 18, 2024
exo-swf pushed a commit to Meeds-io/notes that referenced this issue Oct 18, 2024
)

Prior to this change, when import notes with featured images, the
featured image are not correctly imported due to wrong extraction of
featuredId from exported fileName beside a wrong handle of different
conflict actions.
This PR makes sure to correctly extract the export featured image id to
correctly import featured images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant