fix: Fix Impersonating Addon Containers - MEED-8349 - Meeds-io/meeds#2894 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2894 (#342) Prior to this change, when creating a site **from a template** where we have an `addon container` defined into it with a declared application, then the impersonation process of created site will consider container's children and will attempt to store in database its preferences. This change will ensure to **ignore** `addon container` children which doesn't have a dedicated `StorageId` where to store preferences.
|
MayTekayaa
approved these changes
Feb 7, 2025
exo-swf
pushed a commit
that referenced
this pull request
Feb 7, 2025
…2894 (#343) Prior to this change, when creating a site **from a template** where we have an `addon container` defined into it with a declared application, then the impersonation process of created site will consider container's children and will attempt to store in database its preferences. This change will ensure to **ignore** `addon container` children which doesn't have a dedicated `StorageId` where to store preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when creating a site from a template where we have an
addon containerdefined into it with a declared application, then the impersonation process of created site will consider container's children and will attempt to store in database its preferences. This change will ensure to ignoreaddon containerchildren which doesn't have a dedicatedStorageIdwhere to store preferences.