Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints review (css) #113

Comments

@srenault-meeds
Copy link
Member

srenault-meeds commented Jan 4, 2024

Rationale

No Breakpoint System is precisely identified in the product.

Thus, we have at least 2 Problems:

  • Breakpoints identified in the product are not consistent with the modern UX guidelines. An update is needed
  • Breakpoints are not consistent between JS and CSS

1. Functional Requirements

Breakpoints list is identified as follow:

ID Device Type Screen Size
xs Extra small Small to large phone < 600px
sm Small Small to medium tablet 600px > < 960px
md Medium Large tablet to laptop 960px > < 1264px*
l Large Desktop 1264px > < 1904px*
xl Extra large 4k and ultra-wide > 1904px*

*-16px on desktop for browser scrollbar

Impacts

Check any page to see if impacts to be updated

Gamification

NA

Notifications

NA

Analytics

NA

Unified Search

NA

2. Technical Requirements

Existing Features

The existing Features and classes shouldn't change, thus no Upgrade should be necessary to adopt new breakpoints.

Feature Flags

No feature flags is necessary

3. Software Architecture

Access

The Javascript Breackpoints are defined to use the following breakpoints:

         thresholds: {
           xs: 768,
           sm: 980,
           md: 1024,
           lg: 1280,
           xl: 1700,
         },

It should be changed to use the new ones:

         thresholds: {
           xs: 0,
           sm: 600,
           md: 960,
           lg: 1264,
           xl: 1904,
         },

The same adaptation has to be made in CSS in variables.less :

@smallMobileWidth: 380px;
@maxMobileWidth: 767px;
@minTabletWidth: (@maxMobileWidth + 1px);
@maxTabletWidth: 979px;
@minLargeTabletWidth: (@maxTabletWidth + 1px);
@maxLargeTabletWidth: 1023px;
@minDesktop: (@maxLargeTabletWidth + 1px);
@maxDesktop: 1279px;
@minLargeDesktop: (@maxDesktop + 1px);
@maxLargeDesktop: 1700px;

To be updated by

@smallMobileWidth: 380px;
@maxMobileWidth: 599.98px;
@minTabletWidth: (@maxMobileWidth + 0.02px);
@maxTabletWidth: 959.98px;
@minLargeTabletWidth: (@maxTabletWidth + 0.02px);
@maxLargeTabletWidth: 1263.98px;
@minDesktop: (@maxLargeTabletWidth + 0.02px);
@maxDesktop: 1903.98px;
@minLargeDesktop: (@maxDesktop + 0.02px);

Those variables has to be used consequently in vuetify.less in order to harmonize the display wheter when using Javascript or CSS.

@github-project-automation github-project-automation bot moved this to Open in MIP Board Jan 4, 2024
@srenault-meeds srenault-meeds moved this from Open to Submitted in MIP Board Jan 4, 2024
@srenault-meeds srenault-meeds moved this from Submitted to Open in MIP Board Jan 4, 2024
@srenault-meeds srenault-meeds moved this from Open to Submitted in MIP Board Feb 9, 2024
@srenault-meeds
Copy link
Member Author

@margondicco Can you check please?

@srenault-meeds
Copy link
Member Author

@margondicco after internal discussion, I removed the layout columns as this MIP is only about updating CSS

@srenault-meeds srenault-meeds changed the title Breakpoint System Breakpoints review (css) Feb 9, 2024
@margondicco
Copy link

GO FONC

@srenault-meeds
Copy link
Member Author

Thanks. @boubaker ready for tech spec :)

@boubaker boubaker removed the To check label Feb 9, 2024
@boubaker
Copy link
Member

Thanks. @boubaker ready for tech spec :)

Thanks

@boubaker boubaker self-assigned this Feb 11, 2024
@boubaker
Copy link
Member

Ready for tech review by DAO Members (eXo : @rdenarie )

@boubaker boubaker removed their assignment Feb 12, 2024
@rdenarie
Copy link
Member

Go tech

@boubaker boubaker moved this from Submitted to Accepted in MIP Board Feb 12, 2024
SaraBoutej added a commit to Meeds-io/platform-ui that referenced this issue Feb 14, 2024
SaraBoutej added a commit to Meeds-io/perk-store that referenced this issue Feb 14, 2024
@SaraBoutej
Copy link

Thank you @rdenarie
Merged cc @boubaker

exo-swf pushed a commit to Meeds-io/platform-ui that referenced this issue Feb 28, 2024
)

This PR changes the CSS breakpoints value

(cherry picked from commit 16cb2d5)
exo-swf pushed a commit to Meeds-io/platform-ui that referenced this issue Feb 28, 2024
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
This PR changes the JavaScript and CSS breakpoints value
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…o/MIPs#113 (#3518)

This change fixes The UI Glitch in the spaces list page due to the change in breakpoints
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…3519)

Before this PR, there is a UI glitch in the admin page due to the breakpoints review.
This change allows to fix the admin page display and adapt its breakpoints with the platform breakpoints.

(cherry picked from commit 60dec5a)
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…Ps#113 (#3520)

This change allows to update the breakpoints in the page people list

(cherry picked from commit 922aa2f)
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…eeds-io/MIPs#113 (#3535)

Before this change, when the screen width was between 1264px and 1364px, the activity actions move to the next line.
This PR allows for CSS style adjustments to the activity footer reactions and actions to keep them on a single line.

(cherry picked from commit 8d5197d)
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…MIPs#113 (#3539)

This PR allows to review the UI of the people overview gadget when mobile and tablet.

(cherry picked from commit 0a376a0)
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…3543)

This PR allows to review the UI of the spaces overview gadget when mobile and tablet.

(cherry picked from commit 4169dd0)
rdenarie pushed a commit to Meeds-io/social that referenced this issue Feb 28, 2024
…EED-3377 - Meeds-io/MIPs#113 (#3550)

This change allows to remove the static content displayed when the overview people and space portlets are loading.

(cherry picked from commit 016f357)
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue Feb 28, 2024
…EED-3361 - Meeds-io/MIPs#113 (#1489)

This PR allows to reduce the spacing in the activity contribution action to prevent it from moving to a new line when the screen width is between 1264px and 1364px.

(cherry picked from commit b0dcbe2)
exo-swf pushed a commit to Meeds-io/kudos that referenced this issue Feb 28, 2024
exo-swf pushed a commit to Meeds-io/perk-store that referenced this issue Feb 28, 2024
Meeds-io/MIPs#113 (#323)

This PR allows to update the maxLargeDesktop breakpoint by minLargeDesktop since it is removed from the platform ui variable breakpoints and fix some UI glitch due to the breakpoints changed values.

(cherry picked from commit 97b3ed6)
exo-swf pushed a commit to Meeds-io/meeds-qa-ui that referenced this issue Feb 28, 2024
…io/MIPs#113 (#238)

This fix will consider changes made onactivity reaction likers.

(cherry picked from commit 63debeb)
rdenarie added a commit to exoplatform/news that referenced this issue Mar 20, 2024
…lumn

Meeds-io/MIPs#113 update breakpoint definition
This commit adapts breakpoint usage in news template
rdenarie added a commit to exoplatform/news that referenced this issue Mar 20, 2024
…lumn - EXO- 70464

Meeds-io/MIPs#113 update breakpoint definition
This commit adapts breakpoint usage in news template
rdenarie added a commit to exoplatform/news that referenced this issue Mar 22, 2024
…lumn - EXO- 70464

Meeds-io/MIPs#113 update breakpoint definition
This commit adapts breakpoint usage in news template
rdenarie added a commit to exoplatform/news that referenced this issue Mar 22, 2024
…lumn - EXO- 70464

Meeds-io/MIPs#113 update breakpoint definition
This commit adapts breakpoint usage in news template
rdenarie added a commit to exoplatform/news that referenced this issue Mar 22, 2024
…lumn - EXO-70464

Meeds-io/MIPs#113 update breakpoint definition
This commit adapts breakpoint usage in news template
rdenarie added a commit to exoplatform/news that referenced this issue Mar 22, 2024
…lumn - EXO-70464

Meeds-io/MIPs#113 update breakpoint definition
This commit adapts breakpoint usage in news template
@plamarque plamarque added this to the 1.6.0-M04 milestone Apr 8, 2024
boubaker pushed a commit to Meeds-io/gamification that referenced this issue May 7, 2024
…o/MIPs#113 (#1480)

This PR allows fixing a UI glitch on the program details page on mobile due to the breakpoints change.
boubaker pushed a commit to Meeds-io/gamification that referenced this issue May 7, 2024
…o/MIPs#113 (#1480)

This PR allows fixing a UI glitch on the program details page on mobile due to the breakpoints change.
exo-swf pushed a commit to Meeds-io/gamification that referenced this issue May 7, 2024
…o/MIPs#113 (#1480)

This PR allows fixing a UI glitch on the program details page on mobile due to the breakpoints change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment