-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakpoints review (css) #113
Closed
srenault-meeds opened this issue
Jan 4, 2024
· 16 comments
· Fixed by Meeds-io/social#3557, Meeds-io/kudos#470, Meeds-io/platform-ui#742, Meeds-io/gamification#1491 or Meeds-io/perk-store#324
Closed
Breakpoints review (css) #113
srenault-meeds opened this issue
Jan 4, 2024
· 16 comments
· Fixed by Meeds-io/social#3557, Meeds-io/kudos#470, Meeds-io/platform-ui#742, Meeds-io/gamification#1491 or Meeds-io/perk-store#324
Comments
@margondicco Can you check please? |
@margondicco after internal discussion, I removed the layout columns as this MIP is only about updating CSS |
GO FONC |
Thanks. @boubaker ready for tech spec :) |
Thanks |
Ready for tech review by DAO Members (eXo : @rdenarie ) |
Go tech |
SaraBoutej
added a commit
to Meeds-io/social
that referenced
this issue
Feb 14, 2024
SaraBoutej
added a commit
to Meeds-io/platform-ui
that referenced
this issue
Feb 14, 2024
SaraBoutej
added a commit
to Meeds-io/perk-store
that referenced
this issue
Feb 14, 2024
exo-swf
pushed a commit
to Meeds-io/platform-ui
that referenced
this issue
Feb 28, 2024
) This PR changes the CSS breakpoints value (cherry picked from commit 16cb2d5)
exo-swf
pushed a commit
to Meeds-io/platform-ui
that referenced
this issue
Feb 28, 2024
…EED-3361 - Meeds-io/MIPs#113 (#741) Add new css class helpers (cherry picked from commit d4e31dd)
rdenarie
pushed a commit
to Meeds-io/social
that referenced
this issue
Feb 28, 2024
This PR changes the JavaScript and CSS breakpoints value
rdenarie
pushed a commit
to Meeds-io/social
that referenced
this issue
Feb 28, 2024
…o/MIPs#113 (#3518) This change fixes The UI Glitch in the spaces list page due to the change in breakpoints
rdenarie
pushed a commit
to Meeds-io/social
that referenced
this issue
Feb 28, 2024
…eeds-io/MIPs#113 (#3535) Before this change, when the screen width was between 1264px and 1364px, the activity actions move to the next line. This PR allows for CSS style adjustments to the activity footer reactions and actions to keep them on a single line. (cherry picked from commit 8d5197d)
rdenarie
pushed a commit
to Meeds-io/social
that referenced
this issue
Feb 28, 2024
…EED-3377 - Meeds-io/MIPs#113 (#3550) This change allows to remove the static content displayed when the overview people and space portlets are loading. (cherry picked from commit 016f357)
exo-swf
pushed a commit
to Meeds-io/gamification
that referenced
this issue
Feb 28, 2024
…EED-3361 - Meeds-io/MIPs#113 (#1489) This PR allows to reduce the spacing in the activity contribution action to prevent it from moving to a new line when the screen width is between 1264px and 1364px. (cherry picked from commit b0dcbe2)
exo-swf
pushed a commit
to Meeds-io/kudos
that referenced
this issue
Feb 28, 2024
… - Meeds-io/MIPs#113 (cherry picked from commit 807dd20) (cherry picked from commit a7d51d4)
exo-swf
pushed a commit
to Meeds-io/perk-store
that referenced
this issue
Feb 28, 2024
Meeds-io/MIPs#113 (#323) This PR allows to update the maxLargeDesktop breakpoint by minLargeDesktop since it is removed from the platform ui variable breakpoints and fix some UI glitch due to the breakpoints changed values. (cherry picked from commit 97b3ed6)
exo-swf
pushed a commit
to Meeds-io/meeds-qa-ui
that referenced
this issue
Feb 28, 2024
…io/MIPs#113 (#238) This fix will consider changes made onactivity reaction likers. (cherry picked from commit 63debeb)
rdenarie
added a commit
to exoplatform/news
that referenced
this issue
Mar 20, 2024
…lumn Meeds-io/MIPs#113 update breakpoint definition This commit adapts breakpoint usage in news template
rdenarie
added a commit
to exoplatform/news
that referenced
this issue
Mar 20, 2024
…lumn - EXO- 70464 Meeds-io/MIPs#113 update breakpoint definition This commit adapts breakpoint usage in news template
rdenarie
added a commit
to exoplatform/news
that referenced
this issue
Mar 22, 2024
…lumn - EXO- 70464 Meeds-io/MIPs#113 update breakpoint definition This commit adapts breakpoint usage in news template
rdenarie
added a commit
to exoplatform/news
that referenced
this issue
Mar 22, 2024
…lumn - EXO- 70464 Meeds-io/MIPs#113 update breakpoint definition This commit adapts breakpoint usage in news template
rdenarie
added a commit
to exoplatform/news
that referenced
this issue
Mar 22, 2024
…lumn - EXO-70464 Meeds-io/MIPs#113 update breakpoint definition This commit adapts breakpoint usage in news template
rdenarie
added a commit
to exoplatform/news
that referenced
this issue
Mar 22, 2024
…lumn - EXO-70464 Meeds-io/MIPs#113 update breakpoint definition This commit adapts breakpoint usage in news template
boubaker
pushed a commit
to Meeds-io/gamification
that referenced
this issue
May 7, 2024
…o/MIPs#113 (#1480) This PR allows fixing a UI glitch on the program details page on mobile due to the breakpoints change.
boubaker
pushed a commit
to Meeds-io/gamification
that referenced
this issue
May 7, 2024
…o/MIPs#113 (#1480) This PR allows fixing a UI glitch on the program details page on mobile due to the breakpoints change.
exo-swf
pushed a commit
to Meeds-io/gamification
that referenced
this issue
May 7, 2024
…o/MIPs#113 (#1480) This PR allows fixing a UI glitch on the program details page on mobile due to the breakpoints change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rationale
No Breakpoint System is precisely identified in the product.
Thus, we have at least 2 Problems:
1. Functional Requirements
Breakpoints list is identified as follow:
*-16px on desktop for browser scrollbar
Impacts
Check any page to see if impacts to be updated
Gamification
NA
Notifications
NA
Analytics
NA
Unified Search
NA
2. Technical Requirements
Existing Features
The existing Features and classes shouldn't change, thus no Upgrade should be necessary to adopt new breakpoints.
Feature Flags
No feature flags is necessary
3. Software Architecture
Access
The Javascript Breackpoints are defined to use the following breakpoints:
It should be changed to use the new ones:
The same adaptation has to be made in CSS in variables.less :
To be updated by
Those variables has to be used consequently in vuetify.less in order to harmonize the display wheter when using Javascript or CSS.
The text was updated successfully, but these errors were encountered: