Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Investigate using separate networks for services #1073

Closed
ghost opened this issue Sep 1, 2024 · 1 comment
Closed

docker: Investigate using separate networks for services #1073

ghost opened this issue Sep 1, 2024 · 1 comment
Labels
docker Issues and pull requests related to docker environment enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Sep 1, 2024

Is your feature request related to a problem? Please describe.

In the code review for the new docker / docker compose setup, it was suggested to use separate networks for the php services (see comment).

Describe the solution you'd like

Investigate if and how the services can be split into different networks. The www service should be externally accessible ( and maybe rabbitmq too?). The rest should be able to be shield off and only use the internal network.

Describe alternatives you've considered

N/A

Additional context

See docker compose networking documentation

@ghost ghost added the enhancement New feature or request label Sep 1, 2024
@jwr1 jwr1 added the docker Issues and pull requests related to docker environment label Sep 2, 2024
@melroy89
Copy link
Member

melroy89 commented Sep 7, 2024

I think it's a must have to make this part of #1085.

So I will try to make this part of that PR and interoperate the changes there. Since if you expose all the ports to the external network it will interfere with existing services like PostgreSQL on the host machine. etc..

@melroy89 melroy89 closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Issues and pull requests related to docker environment enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants