Go and Java version. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, by far, the java version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go version, even without routines outperforms, by far, the Java version.
I tried to put every file to be parsed in one different Go routine. Maybe it is possible to put every line to be parsed in a different thread too.
The regex to find names of functions was the worst part. It's hard to build one regex the get all types of functions considering that every language has its grammar.
I sent the Java files too if interested. However, I did not use threads.
I commented the code. Any doubt please contact me: crispolitowski@gmail.com
PS.: I'd like to thanks for the opportunity. I was new with Go language, so I went from 0 knowledge to ... something during this challenge.