Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combat State not Updating #403

Closed
theeneon opened this issue Feb 24, 2025 · 3 comments · Fixed by #404
Closed

Combat State not Updating #403

theeneon opened this issue Feb 24, 2025 · 3 comments · Fixed by #404
Assignees
@MathiasGruber
Labels
fix-me Assigning this label will let OpenHands AI attempt to fix the issue and create a PR.

Comments

@theeneon
Copy link
Collaborator

Describe the bug
When a player is drawn into Combat their combat state does not change to in combat and the player has to refresh before they are taken to combat

To Reproduce
Steps to reproduce the behavior:

  1. Accept a Spar or be attacked
  2. You won't see that you're in combat until you refresh

Expected behavior
When a player is attacked, accept a spar or kage challenge their combat state must be updated and they are taken automatically to the combat screen without needing to refresh.
@theeneon theeneon added the fix-me Assigning this label will let OpenHands AI attempt to fix the issue and create a PR. label Feb 24, 2025
@TheNinja-RPG
Copy link
Collaborator

OpenHands started fixing the issue! You can monitor the progress here.

TheNinja-RPG pushed a commit that referenced this issue Feb 24, 2025
@openhands-agent
Fix issue #403: Combat State not Updating
3a57920
@TheNinja-RPG
Copy link
Collaborator

A potential fix has been generated and a draft PR #404 has been created. Please review the changes.

@TheNinja-RPG TheNinja-RPG mentioned this issue Feb 24, 2025
Merged
@Phrosfire
Copy link
Collaborator

You also have to manually refresh in the tavern as well now. I believe the two might be connected.

MathiasGruber pushed a commit that referenced this issue Feb 26, 2025
@openhands-agent @MathiasGruber
Fix issue #403: Combat State not Updating
9ff2b76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathiasGruber MathiasGruber

Labels
fix-me Assigning this label will let OpenHands AI attempt to fix the issue and create a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #403: Combat State not Updating MathiasGruber/TheNinjaRPG
4 participants
@MathiasGruber @theeneon @Phrosfire @TheNinja-RPG