Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] /files endpoint implementation #1326

Closed
wants to merge 1 commit into from
Closed

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 6, 2022

Related #1225

@ml-evs ml-evs force-pushed the ml-evs/files_endpoint branch from c91d2ca to 5642038 Compare September 6, 2022 10:19
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1326 (5642038) into master (99f47ee) will decrease coverage by 0.30%.
The diff coverage is 68.00%.

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
- Coverage   91.49%   91.19%   -0.31%     
==========================================
  Files          72       75       +3     
  Lines        4364     4418      +54     
==========================================
+ Hits         3993     4029      +36     
- Misses        371      389      +18     
Flag Coverage Δ
project 91.19% <68.00%> (-0.31%) ⬇️
validator 90.60% <68.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/routers/files.py 0.00% <0.00%> (ø)
optimade/models/__init__.py 100.00% <100.00%> (ø)
optimade/models/files.py 100.00% <100.00%> (ø)
optimade/models/responses.py 97.87% <100.00%> (+0.25%) ⬆️
optimade/server/mappers/__init__.py 100.00% <100.00%> (ø)
optimade/server/mappers/files.py 100.00% <100.00%> (ø)
optimade/server/main_index.py 93.10% <0.00%> (-1.64%) ⬇️
optimade/server/routers/utils.py 97.24% <0.00%> (-0.89%) ⬇️
optimade/server/config.py 93.54% <0.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JPBergsma
Copy link
Contributor

I had already started to implement the Files endpoint as well. See my local branch https://github.com/JPBergsma/optimade-python-tools/tree/JPBergsma/add_files_endpoint
I had assigned myself to issue #1225, so I thought it would be clear I was planning to work on this.

@ml-evs
Copy link
Member Author

ml-evs commented Sep 6, 2022

I had already started to implement the Files endpoint as well. See my local branch https://github.com/JPBergsma/optimade-python-tools/tree/JPBergsma/add_files_endpoint I had assigned myself to issue #1225, so I thought it would be clear I was planning to work on this.

Ah okay, I should have checked, I just had some time to kill on the train. Feel free to take stuff from this PR into your branch and I'll close this.

@ml-evs ml-evs closed this Sep 6, 2022
@ml-evs ml-evs deleted the ml-evs/files_endpoint branch December 6, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants