Mark CriteriaBase as obsolete #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanOssendorf
requested changes
Feb 3, 2025
Samples/BusinessRuleDemo/BusinessRuleDemo/BusinessRuleDemo.csproj
Outdated
Show resolved
Hide resolved
Source/Csla/CriteriaBase.cs
Outdated
| @@ -19,6 +19,7 @@ namespace Csla | |||
| /// derived in a business class. | |||
| /// </summary> | |||
| [Serializable] | |||
| [Obsolete("Use normal .NET or CSLA types", false)] | |||
There was a problem hiding this comment.
We should explain that more in detail.
"Use a .Net POCO with a custom serializer or switch to ReadOnlyBase with creation through a dataportal to get a working instance. We recommend the POCO serializer. For more information please check the upgrade guide to CSLA v9"
docs/Upgrading to CSLA 9.md
Outdated
|
|
||
| The `CriteriaBase` class is now obsolete. You should use normal .NET or CSLA-derived types for criteria values instead. | ||
|
|
||
| The most direct replacement for a complex criteria class is to subclass `ReadOnlyBase`. This is because criteria classes are typically read-only, and `ReadOnlyBase` provides the necessary functionality. |
There was a problem hiding this comment.
Please add the remark that those types must be created through a data portal and not with new.
What do we recommend? The POCO serializer or a custom one? Maybe we should mention that.
StefanOssendorf
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4462