add tags field to event data on new vulnerability notifications

when building message notification, use get() to avoid exception when looking up event_data["tags"] use get() to avoid throwing error if key is not found
Marcusk19 · Mar 4, 2024 · 600b605 · 600b605
1 parent 827ca13
commit 600b605
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 15 deletions.
diff --git a/data/secscan_model/secscan_v4_model.py b/data/secscan_model/secscan_v4_model.py
@@ -1,3 +1,4 @@
+import functools
 import itertools
 import logging
 import urllib
@@ -57,6 +58,7 @@
 
 
 DEFAULT_SECURITY_SCANNER_V4_REINDEX_THRESHOLD = 86400  # 1 day
+TAG_LIMIT = 100
 
 IndexReportState = namedtuple("IndexReportState", ["Index_Finished", "Index_Error"])(  # type: ignore[call-arg]
     "IndexFinished", "IndexError"
@@ -454,23 +456,27 @@ def should_skip_indexing(manifest_candidate):
                             import notifications
 
                             keys = list(found_vulnerabilities)
+                            tag_names = list(registry_model.tag_names_for_manifest(manifest, None))
                             for key in keys:
                                 vuln = found_vulnerabilities[key]
 
-                                event_data = {
-                                    "vulnerable_index_report_created": "true",
-                                    "vulnerability": {
-                                        "id": vuln["id"],
-                                        "description": vuln["description"],
-                                        "link": vuln["links"],
-                                        "priority": vuln["severity"],
-                                        "has_fix": bool(vuln["fixed_in_version"]),
-                                    },
-                                }
-
-                                notifications.spawn_notification(
-                                    manifest.repository, "vulnerability_found", event_data
-                                )
+                                for i in range(0, len(tag_names), TAG_LIMIT):
+
+                                    event_data = {
+                                        "tags": list(tag_names[i : i + TAG_LIMIT]),
+                                        "vulnerable_index_report_created": "true",
+                                        "vulnerability": {
+                                            "id": vuln["id"],
+                                            "description": vuln["description"],
+                                            "link": vuln["links"],
+                                            "priority": vuln["severity"],
+                                            "has_fix": bool(vuln["fixed_in_version"]),
+                                        },
+                                    }
+
+                                    notifications.spawn_notification(
+                                        manifest.repository, "vulnerability_found", event_data
+                                    )
 
             elif report["state"] == IndexReportState.Index_Error:
                 index_status = IndexStatus.FAILED

diff --git a/notifications/notificationevent.py b/notifications/notificationevent.py
@@ -247,7 +247,7 @@ def get_summary(self, event_data, notification_data):
             return msg % (
                 event_data[vuln_key][priority_key],
                 event_data["repository"],
-                len(event_data["tags"]),
+                len(event_data.get("tags")),
             )