Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing From impls for dynamically sized types like str, [T], etc. #12

Open
12 tasks
sunjay opened this issue Jun 5, 2020 · 0 comments
Open
12 tasks

Add missing From impls for dynamically sized types like str, [T], etc. #12

sunjay opened this issue Jun 5, 2020 · 0 comments

Comments

@sunjay
Copy link
Contributor

sunjay commented Jun 5, 2020

The difficulty with copying these impls directly from std is that you need to have a version of from_raw that works with ?Sized types. This currently doesn't work because memoffset::offset_of only supports Sized types.

@Manishearth might have a way to do it using the existing support for DSTs.

  • From<&[T]>
  • From<&CStr>
  • From<&OsStr>
  • From<&Path>
  • From<&str>
  • From<Arc<W>>
  • From<Box<T>>
  • From<CString>
  • From<OsString>
  • From<PathBuf>
  • From<String>
  • From<Vec<T>>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunjay