Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PayInReferences attributes readable and instantiable #345

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

toni07
Copy link
Contributor

@toni07 toni07 commented Jan 8, 2025

Make the PayInReferences class introduced in version 2.40.0 attributes readable and instantiable

@iulian03
Copy link
Contributor

iulian03 commented Jan 8, 2025

Hey @toni07,

Thanks for the PR! Could you please use the "builder" pattern for the setter? Just make it return the object after setting the property. Thanks!

@toni07
Copy link
Contributor Author

toni07 commented Jan 8, 2025

Hello @iulian03 , thanks for your fast review.

  • so, you prefer no constructor with arguments, but setters instead, right?
  • for the setters, it seems your code base only uses "regular" setters, like here for example . I would tend to vote for consistency, but I don't have a strong opinion here, as you prefer.

If you confirm me these 2 points, I'll surely push the modifications and let you know!

@iulian03
Copy link
Contributor

iulian03 commented Jan 9, 2025

Lets leave it like this for this case. I will approve the run :D

@alexxmattei alexxmattei merged commit 0ee888f into Mangopay:master Jan 9, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants