Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated get_card_validation method name #321

Merged
merged 2 commits into from
Feb 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/mangopay/core/APIs/CardApi.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
import com.mangopay.core.Pagination;
import com.mangopay.core.Sorting;
import com.mangopay.entities.Card;
import com.mangopay.entities.CardPreAuthorization;
import com.mangopay.entities.CardValidation;
import com.mangopay.entities.Transaction;
import com.mangopay.entities.CardPreAuthorization;

import java.util.List;

Expand Down Expand Up @@ -91,5 +91,5 @@ public interface CardApi {
* @return CardValidation
* @throws Exception
*/
CardValidation get_card_validation(String cardId, String cardValidationId) throws Exception;
CardValidation getCardValidation(String cardId, String cardValidationId) throws Exception;
}
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public CardValidation validate(String cardId, CardValidation cardValidation) thr
return this.createObject(CardValidation.class, null, "card_validate", cardValidation, cardId);
}

public CardValidation get_card_validation(String cardId, String cardValidationId) throws Exception {
public CardValidation getCardValidation(String cardId, String cardValidationId) throws Exception {
return this.getObject(CardValidation.class, "get_card_validation", cardId, cardValidationId);
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/mangopay/core/BaseTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ protected CardValidation getJohnsCardValidation() throws Exception {
cardValidation.setIpAddress("2001:0620:0000:0000:0211:24FF:FE80:C12C");

CardValidation cardValidationResponse = this.api.getCardApi().validate(cardRegistration.getCardId(), cardValidation);
return this.api.getCardApi().get_card_validation(cardRegistration.getCardId(), cardValidationResponse.getId());
return this.api.getCardApi().getCardValidation(cardRegistration.getCardId(), cardValidationResponse.getId());
}

protected KycDocument getJohnsKycDocument() throws Exception {
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/mangopay/core/WalletApiImplTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public void getWalletTransactionsAndSortByCreationDate() throws Exception {
FilterTransactions filter = new FilterTransactions();
filter.setType(TransactionType.PAYIN);

Thread.sleep(2000);
List<Transaction> transactions = this.api.getWalletApi().getTransactions(wallet.getId(), pagination, filter, sorting);

assertNotNull(transactions);
Expand Down
Loading