Passing stacktraces via MethodChannels from Android to Dart is broken

[ueman]

Describe the bug

We see the following issue in production:

To Reproduce
Unfortunately, I don't know how to reproduce this issue.

Expected behavior
The actual real stacktrace should be shown

Sample code to reproduce the problem
Again, unfortunately, I don't know how to solve this problem.

Fix

Fortunately, I know how to fix the issue with the wrongly supported stacktraces.

The following code

https://github.com/MaikuB/flutter_local_notifications/blob/4d8aa14bb6ee12a8c3fa5a29d1eb82a5d57a8fe7/flutter_local_notifications/android/src/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java#L2002C1-L2016C4

should be changed to

  private void getNotificationChannels(Result result) {
    try {
      NotificationManagerCompat notificationManagerCompat =
          getNotificationManager(applicationContext);
      List<NotificationChannel> channels = notificationManagerCompat.getNotificationChannels();
      List<Map<String, Object>> channelsPayload = new ArrayList<>();
      for (NotificationChannel channel : channels) {
        HashMap<String, Object> channelPayload = getMappedNotificationChannel(channel);
        channelsPayload.add(channelPayload);
      }
      result.success(channelsPayload);
    } catch (Throwable e) {
      throw RuntimeException(throwable);
    }
  }

This is documented at https://api.flutter.dev/flutter/services/PlatformException/stacktrace.html

Unfortunately, we lose the GET_NOTIFICATION_CHANNELS_ERROR_CODE for the exception, but due to the issue seen in the screenshot above, it's anyway never used.

I haven't check whether there are any other occurences in the code base. Anyway, passing stacktraces to method channels is not safe, as they can't be serialized.

[Levi-Lesches]

@ueman Fixed by #2103 or are you waiting to use Pigeon/RuntimeException?