refactor: remove unnecessary setting the timer again when pausing the…

… timer
MaibornWolff · Dec 15, 2023 · b53383f · b53383f
1 parent 5f2b7a7
commit b53383f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 15 deletions.
diff --git a/packages/frontend/src/retro/components/dialogs/TimerDialog.tsx b/packages/frontend/src/retro/components/dialogs/TimerDialog.tsx
@@ -26,7 +26,7 @@ export function TimerDialog({
     handleResumeTimer,
     handleChangeTimer,
   } = useRetroContext();
-  const { timerStatus, timerDuration } = retroState;
+  const { timerStatus } = retroState;
   const isTimerRunning = timerStatus === TimerStatus.RUNNING;
   const isTimerPaused = timerStatus === TimerStatus.PAUSED;
   const isTimerStopped = timerStatus === TimerStatus.STOPPED;
@@ -98,15 +98,7 @@ export function TimerDialog({
       </DialogContent>
       <DialogActions>
         <Button onClick={close}>Cancel</Button>
-        {isTimerRunning && (
-          <Button
-            onClick={() => {
-              handlePauseTimer(timerDuration);
-            }}
-          >
-            Pause
-          </Button>
-        )}
+        {isTimerRunning && <Button onClick={handlePauseTimer}>Pause</Button>}
         {isTimerPaused && <Button onClick={handleResumeTimer}>Resume</Button>}
         <CallToActionButton
           onClick={isTimerStopped ? handleStartClick : handleStopClick}

diff --git a/packages/frontend/src/retro/context/RetroContext.tsx b/packages/frontend/src/retro/context/RetroContext.tsx
@@ -83,7 +83,7 @@ export interface RetroContextValues {
   handleAddToWaitingList: (payload: AddToWaitingListAction["payload"]) => void;
   handleIsVotingEnabledChanged: (isEnabled: boolean) => void;
   handleStartTimer: (duration: number) => void;
-  handlePauseTimer: (duration: number) => void;
+  handlePauseTimer: () => void;
   handleChangeTimer: (duration: number) => void;
   handleStopTimer: () => void;
   handleResumeTimer: () => void;
@@ -233,8 +233,8 @@ export function RetroContextProvider(props: RetroContextProviderProps) {
     dispatchAndBroadcast({ type: "START_TIMER", duration });
   }
 
-  function handlePauseTimer(duration: StartTimerAction["duration"]) {
-    dispatchAndBroadcast({ type: "PAUSE_TIMER", duration });
+  function handlePauseTimer() {
+    dispatchAndBroadcast({ type: "PAUSE_TIMER" });
   }
 
   function handleStopTimer() {

diff --git a/packages/frontend/src/retro/reducers/retroReducer.ts b/packages/frontend/src/retro/reducers/retroReducer.ts
@@ -235,7 +235,7 @@ export const retroReducer = (state: RetroState, action: RetroAction): RetroState
       return { ...state, timerDuration: 0, timerStatus: TimerStatus.STOPPED };
     }
     case "PAUSE_TIMER": {
-      return { ...state, timerDuration: action.duration, timerStatus: TimerStatus.PAUSED };
+      return { ...state, timerStatus: TimerStatus.PAUSED };
     }
     case "CHANGE_TIMER": {
       return { ...state, timerDuration: action.duration };

diff --git a/packages/frontend/src/retro/types/retroActions.ts b/packages/frontend/src/retro/types/retroActions.ts
@@ -99,13 +99,15 @@ export interface StartTimerAction extends BaseAction {
   type: "START_TIMER";
   duration: number;
 }
+
 export interface PauseTimerAction extends BaseAction {
   type: "PAUSE_TIMER";
-  duration: number;
 }
+
 export interface StopTimerAction extends BaseAction {
   type: "STOP_TIMER";
 }
+
 export interface ChangeTimerAction extends BaseAction {
   type: "CHANGE_TIMER";
   duration: number;