Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exchange rate #1584

Conversation

zmcNotafraid
Copy link
Member

What problem does this PR solve?

If coinmarketcap can't fetch price, returns 0 as default.

Check List

Test

  • unit test

Task

  • none

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 625063725c77936b2ef6fd6c6b6407dfb13e3b1a-PR-1584

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 55.051%

Files with Coverage Reduction New Missed Lines %
lib/godwoken_explorer/graphql/types/custom/bigint.ex 1 0.0%
lib/godwoken_explorer/graphql/types/custom/custom.ex 2 3.33%
Totals Coverage Status
Change from base Build 2457e55af34650c199f854864cb3d280714551db: -0.03%
Covered Lines: 3324
Relevant Lines: 6038

💛 - Coveralls

@zmcNotafraid zmcNotafraid merged commit 8af6539 into Magickbase:godwoken-v1-testnet-prod Feb 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants