Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add VehicleSync::UpdateData to vehicle entity #116

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Deewarz
Copy link
Contributor

@Deewarz Deewarz commented Jan 15, 2025

I accidentally removed the addition of VehicleSync::UpdateData on the vehicle entity

a2e42f7#diff-9da33544966d1e2c2602e3066a4cd1a10ea0c7f81bb799e45ba69ca74638d94dL51

As explained by @zpl-zak we need it:

ensure() call does both add the component and retrieve a reference
otherwise the entity has incomplete data and can not be considered a valid Vehicle
we will eventually start using ecs prefabs, so it becomes more obvious what components the entities consist of, but for now we just attach components as we go

@Deewarz Deewarz self-assigned this Jan 15, 2025
@Deewarz Deewarz requested a review from zpl-zak January 15, 2025 18:04
@Segfaultd Segfaultd merged commit 922f00e into master Jan 15, 2025
1 check passed
@Segfaultd Segfaultd deleted the fix/add-update-data-to-vehicle-entity branch January 15, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants