From 72c955fd09f6718dec7b2feadd39094374b6b30f Mon Sep 17 00:00:00 2001 From: Duncan Lock Date: Thu, 7 May 2015 17:48:40 -0700 Subject: [PATCH 1/3] Spelling and grammar fixes crates -> creates --- tutorials/cell-editor.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorials/cell-editor.html b/tutorials/cell-editor.html index 4d98bd1..4fe405f 100644 --- a/tutorials/cell-editor.html +++ b/tutorials/cell-editor.html @@ -386,7 +386,7 @@

Creating <select }

Task two: DONE

Populating <select> with options

-

In the previous step we implemented a function that crates <select> input and attaches it to DOM. +

In the previous step we implemented a function that creates <select> input and attaches it to DOM. You've probably noticed that we haven't written any code that would create <option> elements, therefore if we would display the list, it would be From 81b194a35c55aa15e664ae91d876f47503de9944 Mon Sep 17 00:00:00 2001 From: Duncan Lock Date: Thu, 7 May 2015 17:56:56 -0700 Subject: [PATCH 2/3] Spelling and grammar fixes --- tutorials/cell-editor.html | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tutorials/cell-editor.html b/tutorials/cell-editor.html index 4fe405f..4f24270 100644 --- a/tutorials/cell-editor.html +++ b/tutorials/cell-editor.html @@ -386,11 +386,10 @@

Creating <select }

Task two: DONE

Populating <select> with options

-

In the previous step we implemented a function that creates <select> input and attaches it to DOM. +

In the previous step we implemented a function that creates the <select> input and attaches it to the DOM. You've probably noticed - that we haven't written any code that would create <option> elements, therefore if we would - display the list, it would be - empty.

+ that we haven't written any code that would create the <option> elements, therefore if we + displayed the list, it would be empty.

We want to be able to define an option list like so:

var hot = new Handsontable(document.getElementById('container'), {
   data: someData,

From c73a08268af5d4cd9aeaeb4fc8697e2701fe1d00 Mon Sep 17 00:00:00 2001
From: Duncan Lock 
Date: Thu, 7 May 2015 18:02:37 -0700
Subject: [PATCH 3/3] Spelling and grammar fixes

---
 tutorials/cell-editor.html | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tutorials/cell-editor.html b/tutorials/cell-editor.html
index 4f24270..4a01546 100644
--- a/tutorials/cell-editor.html
+++ b/tutorials/cell-editor.html
@@ -387,10 +387,9 @@ 
Creating <select
     
Task two: DONE

     
Populating <select> with options

     
In the previous step we implemented a function that creates the <select> input and attaches it to the DOM.
-      You've probably noticed
-      that we haven't written any code that would create the <option> elements, therefore if we
+      You probably noticed that we haven't written any code that would create the <option> elements, therefore if we
       displayed the list, it would be empty.

-    
We want to be able to define an option list like so:

+    
We want to be able to define an option list like this:

     
var hot = new Handsontable(document.getElementById('container'), {
   data: someData,
   columns: [
@@ -401,9 +400,8 @@ 
Populating <select> w
   ]
 });

     
There is no (easy) way to get to the value of selectOptions. Even if we could get to this array we could
-      only populate
-      list with options once, what if we have more than one column using SelectEditor and each of them has it's
-      own option list.
+      only populate the list with options once, if we do this in the 'init' function.
+      What if we have more than one column using SelectEditor and each of them has it's own option list?
       It's even possible that two cells in the same column can have different option lists (cascade configuration -
       remember?)
       It's clear that we have to find a better place for the code that creates items for our list.