-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Documentation Preview Action #84
Conversation
Thanks @ssolson. Is there a way to automatically purge the PR-previews once the relevant PR is merged or closed? Maybe
|
@akeeste what previews directory are you talking about? Or I am not sure what your purge concern is here. Previews are at: Actual docs are on |
Never mind I see your point now. Let me address that by adding a removal action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ssolson , looks good to merge
@akeeste I tried once more to make the preview builds auto trigger on a PR but there are security issues with allowing an outside contributor to trigger deployments so I went back to the manual deploy. |
That makes sense. An automatic preview opens up the possibility for anything to appear on our documentation. The manually deployed preview will still be very helpful and seems pretty easy to trigger once implemented |
* manual preview action * delete all previews on merge or close
* manual preview action * delete all previews on merge or close
Once merged into main this will allow us to manually trigger a preview build of any docs PR to check that link ect are working correctly:
The preview will be available at:
https://mhkit-software.github.io/MHKiT/pr-previews/<PR#>/
Once merged into main to trigger the preview: