Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error from api.clean.find_surface_from_P(ds, salinity=XX) #353

Closed
calumkenny opened this issue Sep 18, 2024 · 1 comment · Fixed by #354
Closed

Error from api.clean.find_surface_from_P(ds, salinity=XX) #353

calumkenny opened this issue Sep 18, 2024 · 1 comment · Fixed by #354
Assignees
@jmcvey3
Labels
bug Something isn't working

Comments

@calumkenny
Copy link
Contributor

Describe the bug:

Error experienced when running api.clean.find_surface_from_P(ds, salinity=XX) function:

AttributeError: 'NoneType' object has no attribute 'pressure'

To Reproduce:

Use function on RDI ADCP without pressure variable.

Expected behavior:

Error occurs.

Additional context:

Working session with @jmcvey3.
@ssolson ssolson added the bug Something isn't working label Sep 18, 2024
@jmcvey3 jmcvey3 mentioned this issue Sep 18, 2024
Merged
@ssolson ssolson linked a pull request Oct 29, 2024 that will close this issue
Dolfyn cleaning function updates #354
Merged
ssolson pushed a commit that referenced this issue Nov 27, 2024
@jmcvey3
Dolfyn cleaning function updates (#354)
79f69ca 
- Rename and enhance water depth calculation and surface interference removal functions for improved robustness.
- Adjust functions to account for RDI ADCP calculations in addition to Nortek devices.
- Add errors and warnings to guide users when previous calculations are complete or data is missing.
- Remove "ignore rankwarning" to respect user preferences; update code for future package deprecations.
- Fix issues identified in Issue #353 and update tests accordingly.
- Correct determination of beam angle and carrier frequency attributes for Sentinel V ADCPs.
@ssolson ssolson closed this as completed Dec 3, 2024
@akeeste
Copy link
Contributor

akeeste commented Dec 3, 2024

Resolved with #354

@ssolson ssolson mentioned this issue Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcvey3 jmcvey3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dolfyn cleaning function updates jmcvey3/MHKiT-Python
4 participants
@ssolson @calumkenny @jmcvey3 @akeeste