Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Module/Datapoints): add new History chart for data channels #194

Merged
merged 6 commits into from
Mar 8, 2017

Conversation

evenchange4
Copy link
Member

@evenchange4 evenchange4 commented Mar 8, 2017

  • test

for #173

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 8, 2017

Deploy preview ready!

Built with commit 876139e

https://deploy-preview-194--mcs-lite-mobile-web.netlify.com

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 8, 2017

Deploy preview ready!

Built with commit 876139e

https://deploy-preview-194--mcs-lite-ui.netlify.com

@evenchange4
Copy link
Member Author

evenchange4 commented Mar 8, 2017

Codecov Report

Merging #194 into master will increase coverage by 1.36%.
The diff coverage is 94%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   85.58%   86.95%   +1.36%     
==========================================
  Files         120      121       +1     
  Lines         895      935      +40     
==========================================
+ Hits          766      813      +47     
+ Misses        129      122       -7
Impacted Files Coverage Δ
packages/mcs-lite-mobile-web/src/modules/auth.js 95.08% <ø> (ø)
...le-web/src/containers/DeviceDetail/DeviceDetail.js 53.33% <ø> (ø)
...src/containers/DeviceDataChannelDetail/messages.js 100% <ø> (ø)
packages/mcs-lite-mobile-web/src/modules/index.js 100% <ø> (ø)
...te-mobile-web/src/containers/DeviceDetail/index.js 60% <0%> (ø)
...ackages/mcs-lite-mobile-web/src/modules/devices.js 100% <100%> (ø)
...DeviceDataChannelDetail/DeviceDataChannelDetail.js 64.28% <100%> (+56.59%)
...eb/src/containers/DeviceDataChannelDetail/index.js 66.66% <66.66%> (+6.66%)
...ages/mcs-lite-mobile-web/src/modules/datapoints.js 97.36% <97.36%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2946d...876139e. Read the comment docs.

@michaelhsu-bot
Copy link
Collaborator

michaelhsu-bot commented Mar 8, 2017

Warnings
⚠️ ❗ Big PR

Generated by 🚫 dangerJS

@evenchange4 evenchange4 force-pushed the feature/datapoionts-history branch from cad3491 to fa1984b Compare March 8, 2017 06:16
@evenchange4 evenchange4 merged commit bae2173 into master Mar 8, 2017
@evenchange4 evenchange4 deleted the feature/datapoionts-history branch March 8, 2017 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants